FT-853: Implement query rewrite for Searchlog responses #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t turns on time-based pagination
Aryamanz29
approved these changes
Dec 25, 2024
There was a problem hiding this comment.
LGTM 🚀
- I made some changes to your
unitandintegrationtests to ensure pagination is properly executed within the test cases. Previously, you were only asserting checks like this:
assert len(results.current_page()) == size
assert results.count == total_countThis isn't sufficient ^^ as we also need to iterate over the results and confirm that the iteration count == TOTAL_LOG_ENTRIES (as returned by the API response) ✅
Also, I noticed that several assertions were missing in your unit tests. For example, we should include assertions like:
assert mock_logger.call_count == 0
...
...
assert mock_api_caller._call_api.call_count == 2We might need to update the audit unit and integration tests as well to follow the same approach ^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a query rewrite for a time-based pagination approach for search, known as bulk search, based on asset creation timestamps. This approach is used when the number of results exceeds the predefined threshold (i.e: 10,000 assets). Users can explicitly run this search by setting the optional keyword argument bulk=True in the search_log.search() methods.